Merge branch 'feature/inflow-control-improvement' into master

This commit is contained in:
curry772
2026-05-08 10:51:48 +09:00
22 changed files with 1284 additions and 439 deletions
@@ -0,0 +1,239 @@
package com.eactive.eai.custom.inbound.processor;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.*;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.springframework.context.ApplicationContext;
import org.springframework.test.util.ReflectionTestUtils;
import com.eactive.eai.common.inflow.Bucket;
import com.eactive.eai.common.inflow.InflowTargetVO;
import com.eactive.eai.common.inflow.dual.ClientDualBucket;
import com.eactive.eai.common.inflow.dual.DualBucket;
import com.eactive.eai.common.inflow.dual.DualCustomBucket;
import com.eactive.eai.common.server.EAIServerManager;
import com.eactive.eai.common.util.ApplicationContextProvider;
/**
* DJBRequestProcessor 단위 테스트.
*
* <p>RequestProcessor 클래스는 static 초기화 블록에서 EAIServerManager.getInstance()를 호출한다.
* @BeforeAll에서 mock ApplicationContext를 주입한 뒤 DJBRequestProcessor를 최초 로딩시킨다.
*
* <p>주의: DJBRequestProcessor를 필드 타입으로 선언하면 테스트 클래스 로딩 시 함께 로딩되어
* @BeforeAll 실행 전에 NPE가 발생한다. 반드시 메서드 본문 내에서만 참조해야 한다.
*/
class DJBRequestProcessorTest {
@BeforeAll
static void setupMockApplicationContext() {
ApplicationContext mockContext = mock(ApplicationContext.class);
EAIServerManager mockServerManager = mock(EAIServerManager.class);
when(mockContext.getBean(EAIServerManager.class)).thenReturn(mockServerManager);
when(mockServerManager.getLocalServerName()).thenReturn("TEST-SERVER");
when(mockServerManager.getGroupInstId()).thenReturn("TEST-INST");
ReflectionTestUtils.setField(ApplicationContextProvider.class, "context", mockContext);
}
private InflowTargetVO makeVO(String name, long perSec, long threshold, String unit) {
InflowTargetVO vo = new InflowTargetVO();
vo.setName(name);
vo.setThresholdPerSecond(perSec);
vo.setThreshold(threshold);
vo.setThresholdTimeUnit(unit);
vo.setActivate(true);
return vo;
}
// -------------------------------------------------------------------------
// checkAdapterInflow
// -------------------------------------------------------------------------
@Test
void checkAdapterInflow_dualBucket_pass_returnsNull() {
DJBRequestProcessor processor = new DJBRequestProcessor();
DualBucket mockBucket = mock(DualBucket.class);
when(mockBucket.isAdapterPassDetail("ADAPTER_A")).thenReturn(null);
assertNull(processor.checkAdapterInflow(mockBucket, "ADAPTER_A"));
verify(mockBucket).isAdapterPassDetail("ADAPTER_A");
}
@Test
void checkAdapterInflow_dualBucket_blockedPerSecond() {
DJBRequestProcessor processor = new DJBRequestProcessor();
DualBucket mockBucket = mock(DualBucket.class);
when(mockBucket.isAdapterPassDetail("ADAPTER_A")).thenReturn(DualCustomBucket.RESULT_BLOCKED_PER_SECOND);
assertEquals(DualCustomBucket.RESULT_BLOCKED_PER_SECOND,
processor.checkAdapterInflow(mockBucket, "ADAPTER_A"));
}
@Test
void checkAdapterInflow_dualBucket_blockedThreshold() {
DJBRequestProcessor processor = new DJBRequestProcessor();
DualBucket mockBucket = mock(DualBucket.class);
when(mockBucket.isAdapterPassDetail("ADAPTER_A")).thenReturn(DualCustomBucket.RESULT_BLOCKED_THRESHOLD);
assertEquals(DualCustomBucket.RESULT_BLOCKED_THRESHOLD,
processor.checkAdapterInflow(mockBucket, "ADAPTER_A"));
}
@Test
void checkAdapterInflow_nonDualBucket_pass_returnsNull() {
DJBRequestProcessor processor = new DJBRequestProcessor();
Bucket mockBucket = mock(Bucket.class);
when(mockBucket.isAdapterPass("ADAPTER_A")).thenReturn(true);
assertNull(processor.checkAdapterInflow(mockBucket, "ADAPTER_A"));
}
@Test
void checkAdapterInflow_nonDualBucket_blocked_returnsBlocked() {
DJBRequestProcessor processor = new DJBRequestProcessor();
Bucket mockBucket = mock(Bucket.class);
when(mockBucket.isAdapterPass("ADAPTER_A")).thenReturn(false);
assertEquals("BLOCKED", processor.checkAdapterInflow(mockBucket, "ADAPTER_A"));
}
// -------------------------------------------------------------------------
// checkInterfaceInflow
// -------------------------------------------------------------------------
@Test
void checkInterfaceInflow_dualBucket_pass_returnsNull() {
DJBRequestProcessor processor = new DJBRequestProcessor();
DualBucket mockBucket = mock(DualBucket.class);
when(mockBucket.isInterfacePassDetail("IF_001")).thenReturn(null);
assertNull(processor.checkInterfaceInflow(mockBucket, "IF_001"));
verify(mockBucket).isInterfacePassDetail("IF_001");
}
@Test
void checkInterfaceInflow_dualBucket_blockedPerSecond() {
DJBRequestProcessor processor = new DJBRequestProcessor();
DualBucket mockBucket = mock(DualBucket.class);
when(mockBucket.isInterfacePassDetail("IF_001")).thenReturn(DualCustomBucket.RESULT_BLOCKED_PER_SECOND);
assertEquals(DualCustomBucket.RESULT_BLOCKED_PER_SECOND,
processor.checkInterfaceInflow(mockBucket, "IF_001"));
}
@Test
void checkInterfaceInflow_nonDualBucket_pass_returnsNull() {
DJBRequestProcessor processor = new DJBRequestProcessor();
Bucket mockBucket = mock(Bucket.class);
when(mockBucket.isInterfacePass("IF_001")).thenReturn(true);
assertNull(processor.checkInterfaceInflow(mockBucket, "IF_001"));
}
@Test
void checkInterfaceInflow_nonDualBucket_blocked_returnsBlocked() {
DJBRequestProcessor processor = new DJBRequestProcessor();
Bucket mockBucket = mock(Bucket.class);
when(mockBucket.isInterfacePass("IF_001")).thenReturn(false);
assertEquals("BLOCKED", processor.checkInterfaceInflow(mockBucket, "IF_001"));
}
// -------------------------------------------------------------------------
// checkClientInflow — ClientDualBucket 기반
// -------------------------------------------------------------------------
@Test
void checkClientInflow_clientDualBucket_pass_returnsNull() {
DJBRequestProcessor processor = new DJBRequestProcessor();
ClientDualBucket mockBucket = mock(ClientDualBucket.class);
when(mockBucket.isClientPassDetail("CLIENT_A")).thenReturn(null);
assertNull(processor.checkClientInflow(mockBucket, "CLIENT_A"));
verify(mockBucket).isClientPassDetail("CLIENT_A");
}
@Test
void checkClientInflow_clientDualBucket_blocked() {
DJBRequestProcessor processor = new DJBRequestProcessor();
ClientDualBucket mockBucket = mock(ClientDualBucket.class);
when(mockBucket.isClientPassDetail("CLIENT_A")).thenReturn(DualCustomBucket.RESULT_BLOCKED_THRESHOLD);
assertEquals(DualCustomBucket.RESULT_BLOCKED_THRESHOLD,
processor.checkClientInflow(mockBucket, "CLIENT_A"));
}
@Test
void checkClientInflow_nonClientDualBucket_returnsNull() {
DJBRequestProcessor processor = new DJBRequestProcessor();
Bucket mockBucket = mock(Bucket.class);
assertNull(processor.checkClientInflow(mockBucket, "CLIENT_A"));
}
@Test
void checkClientInflow_blankClientId_returnsNull() {
DJBRequestProcessor processor = new DJBRequestProcessor();
ClientDualBucket mockBucket = mock(ClientDualBucket.class);
assertNull(processor.checkClientInflow(mockBucket, ""));
verify(mockBucket, never()).isClientPassDetail(any());
}
// -------------------------------------------------------------------------
// buildInflowTargetErrorMsg
// -------------------------------------------------------------------------
@Test
void buildInflowTargetErrorMsg_perSecond_includesReqPerSec() {
DJBRequestProcessor processor = new DJBRequestProcessor();
InflowTargetVO vo = makeVO("결제API", 30, 1000, "MIN");
String msg = processor.buildInflowTargetErrorMsg(vo, DualCustomBucket.RESULT_BLOCKED_PER_SECOND);
assertEquals("API 호출 한도 초과 [결제API: 30req/sec]", msg);
}
@Test
void buildInflowTargetErrorMsg_threshold_includesReqPerUnit() {
DJBRequestProcessor processor = new DJBRequestProcessor();
InflowTargetVO vo = makeVO("결제API", 30, 1000, "MIN");
String msg = processor.buildInflowTargetErrorMsg(vo, DualCustomBucket.RESULT_BLOCKED_THRESHOLD);
assertEquals("API 호출 한도 초과 [결제API: 1000req/MIN]", msg);
}
@Test
void buildInflowTargetErrorMsg_blockedFallback_simpleFormat() {
DJBRequestProcessor processor = new DJBRequestProcessor();
InflowTargetVO vo = makeVO("결제API", 30, 1000, "MIN");
String msg = processor.buildInflowTargetErrorMsg(vo, "BLOCKED");
assertEquals("API 호출 한도 초과 [결제API]", msg);
}
@Test
void buildInflowTargetErrorMsg_nullBlockedType_simpleFormat() {
DJBRequestProcessor processor = new DJBRequestProcessor();
InflowTargetVO vo = makeVO("결제API", 30, 1000, "MIN");
String msg = processor.buildInflowTargetErrorMsg(vo, null);
assertEquals("API 호출 한도 초과 [결제API]", msg);
}
@Test
void buildInflowTargetErrorMsg_hourUnit() {
DJBRequestProcessor processor = new DJBRequestProcessor();
InflowTargetVO vo = makeVO("조회API", 10, 500, "HOUR");
String msg = processor.buildInflowTargetErrorMsg(vo, DualCustomBucket.RESULT_BLOCKED_THRESHOLD);
assertEquals("API 호출 한도 초과 [조회API: 500req/HOUR]", msg);
}
}
@@ -0,0 +1,106 @@
package com.eactive.eai.custom.inflow;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.*;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.springframework.http.ResponseEntity;
import org.springframework.test.util.ReflectionTestUtils;
import com.eactive.eai.manage.inflow.TargetBucketStatusDTO;
/**
* ClientInflowTargetBucketController 단위 테스트.
*/
class ClientInflowTargetBucketControllerTest {
private ClientInflowTargetBucketController controller;
private ClientInflowTargetBucketService mockService;
@BeforeEach
void setUp() {
controller = new ClientInflowTargetBucketController();
mockService = mock(ClientInflowTargetBucketService.class);
ReflectionTestUtils.setField(controller, "bucketService", mockService);
}
private TargetBucketStatusDTO makeDTO(String id, String type) {
TargetBucketStatusDTO dto = new TargetBucketStatusDTO();
dto.setTargetId(id);
dto.setTargetType(type);
dto.setActivate(true);
dto.setBuckets(Collections.emptyList());
return dto;
}
@SuppressWarnings("unchecked")
private Map<String, Object> body(ResponseEntity<?> response) {
return (Map<String, Object>) response.getBody();
}
// =========================================================================
// 단일 조회
// =========================================================================
@Test
void getClientBucketStatus_found_successTrueAndDataPresent() {
TargetBucketStatusDTO dto = makeDTO("CLIENT_A", "CLIENT");
when(mockService.getClientBucketStatus("CLIENT_A")).thenReturn(dto);
ResponseEntity<?> response = controller.getClientBucketStatus("CLIENT_A");
Map<String, Object> body = body(response);
assertEquals(200, response.getStatusCodeValue());
assertEquals(Boolean.TRUE, body.get("success"));
assertSame(dto, body.get("data"));
assertFalse(body.containsKey("message"));
}
@Test
void getClientBucketStatus_notFound_successFalseWithClientId() {
when(mockService.getClientBucketStatus("CLIENT_X")).thenReturn(null);
ResponseEntity<?> response = controller.getClientBucketStatus("CLIENT_X");
Map<String, Object> body = body(response);
assertEquals(Boolean.FALSE, body.get("success"));
assertTrue(body.get("message").toString().contains("CLIENT_X"));
}
// =========================================================================
// 전체 조회
// =========================================================================
@Test
void getAllClientBucketStatus_returnsListAndCount() {
List<TargetBucketStatusDTO> list = Arrays.asList(
makeDTO("CLIENT_A", "CLIENT"),
makeDTO("CLIENT_B", "CLIENT"),
makeDTO("CLIENT_C", "CLIENT")
);
when(mockService.getAllClientBucketStatus()).thenReturn(list);
ResponseEntity<?> response = controller.getAllClientBucketStatus();
Map<String, Object> body = body(response);
assertEquals(Boolean.TRUE, body.get("success"));
assertSame(list, body.get("data"));
assertEquals(3, body.get("count"));
}
@Test
void getAllClientBucketStatus_emptyList_countZero() {
when(mockService.getAllClientBucketStatus()).thenReturn(Collections.emptyList());
Map<String, Object> body = body(controller.getAllClientBucketStatus());
assertEquals(Boolean.TRUE, body.get("success"));
assertEquals(0, body.get("count"));
}
}
@@ -0,0 +1,208 @@
package com.eactive.eai.custom.inflow;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.*;
import java.time.Duration;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import org.junit.jupiter.api.Test;
import com.eactive.eai.common.inflow.InflowTargetVO;
import com.eactive.eai.common.inflow.dual.ClientDualInflowControlManager;
import com.eactive.eai.common.inflow.dual.DualCustomBucket;
import com.eactive.eai.manage.inflow.GroupBucketStatusDTO;
import com.eactive.eai.manage.inflow.TargetBucketStatusDTO;
import io.github.bucket4j.Bandwidth;
import io.github.bucket4j.Bucket4j;
import io.github.bucket4j.local.LocalBucket;
/**
* ClientInflowTargetBucketService 단위 테스트.
*/
class ClientInflowTargetBucketServiceTest {
// -------------------------------------------------------------------------
// 테스트용 서브클래스
// -------------------------------------------------------------------------
private static ClientInflowTargetBucketService serviceWith(ClientDualInflowControlManager manager) {
return new ClientInflowTargetBucketService() {
@Override
protected ClientDualInflowControlManager getClientDualManager() { return manager; }
};
}
// -------------------------------------------------------------------------
// Helpers
// -------------------------------------------------------------------------
private InflowTargetVO makeVO(String name, long perSec, long threshold, String unit, boolean activate) {
InflowTargetVO vo = new InflowTargetVO();
vo.setName(name);
vo.setThresholdPerSecond(perSec);
vo.setThreshold(threshold);
vo.setThresholdTimeUnit(unit);
vo.setActivate(activate);
return vo;
}
private LocalBucket freshBucket(long capacity) {
return Bucket4j.builder()
.addLimit(Bandwidth.simple(capacity, Duration.ofSeconds(1)))
.build();
}
private LocalBucket exhaustedBucket(long capacity) {
LocalBucket b = freshBucket(capacity);
b.tryConsume(capacity);
return b;
}
private DualCustomBucket makeDualBucket(String name, long perSec, long threshold) {
return new DualCustomBucket(freshBucket(perSec), freshBucket(threshold),
makeVO(name, perSec, threshold, "DAY", true));
}
// =========================================================================
// ClientDualManager null (비활성 환경)
// =========================================================================
@Test
void getClientBucketStatus_managerIsNull_returnsNull() {
assertNull(serviceWith(null).getClientBucketStatus("CLIENT_A"));
}
@Test
void getAllClientBucketStatus_managerIsNull_returnsEmptyList() {
assertTrue(serviceWith(null).getAllClientBucketStatus().isEmpty());
}
// =========================================================================
// 버킷 미존재
// =========================================================================
@Test
void getClientBucketStatus_notFound_returnsNull() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientBucket("CLIENT_A")).thenReturn(null);
assertNull(serviceWith(manager).getClientBucketStatus("CLIENT_A"));
}
// =========================================================================
// 단일 조회 — targetType, targetId 매핑
// =========================================================================
@Test
void getClientBucketStatus_found_mapsClientType() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientBucket("CLIENT_A")).thenReturn(makeDualBucket("CLIENT_A", 50, 5000));
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("CLIENT_A");
assertNotNull(dto);
assertEquals("CLIENT_A", dto.getTargetId());
assertEquals("CLIENT", dto.getTargetType());
assertTrue(dto.isActivate());
assertEquals(2, dto.getBuckets().size());
}
// =========================================================================
// BucketInfo 타입별 포함 여부
// =========================================================================
@Test
void toDto_onlyThreshold_bucketInfoHasOneThresholdEntry() {
InflowTargetVO vo = makeVO("C1", 0, 1000, "DAY", true);
DualCustomBucket bucket = new DualCustomBucket(null, freshBucket(1000), vo);
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientBucket("C1")).thenReturn(bucket);
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C1");
assertEquals(1, dto.getBuckets().size());
assertEquals("threshold", dto.getBuckets().get(0).getType());
}
@Test
void toDto_onlyPerSecond_bucketInfoHasOnePerSecondEntry() {
InflowTargetVO vo = makeVO("C2", 100, 0, null, true);
DualCustomBucket bucket = new DualCustomBucket(freshBucket(100), null, vo);
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientBucket("C2")).thenReturn(bucket);
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C2");
assertEquals(1, dto.getBuckets().size());
assertEquals("perSecond", dto.getBuckets().get(0).getType());
}
@Test
void toDto_bothBuckets_bucketInfoHasTwoEntries() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientBucket("C3")).thenReturn(makeDualBucket("C3", 100, 5000));
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C3");
assertEquals(2, dto.getBuckets().size());
assertEquals("perSecond", dto.getBuckets().get(0).getType());
assertEquals("threshold", dto.getBuckets().get(1).getType());
}
// =========================================================================
// 사용률 계산
// =========================================================================
@Test
void toDto_exhaustedThreshold_usagePercentIs100() {
InflowTargetVO vo = makeVO("C4", 0, 100, "DAY", true);
DualCustomBucket bucket = new DualCustomBucket(null, exhaustedBucket(100), vo);
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientBucket("C4")).thenReturn(bucket);
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C4");
GroupBucketStatusDTO.BucketInfo info = dto.getBuckets().get(0);
assertEquals(0, info.getAvailableTokens());
assertEquals(100.0, info.getUsagePercent(), 0.01);
}
@Test
void toDto_freshBucket_usagePercentIsZero() {
InflowTargetVO vo = makeVO("C5", 0, 100, "DAY", true);
DualCustomBucket bucket = new DualCustomBucket(null, freshBucket(100), vo);
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientBucket("C5")).thenReturn(bucket);
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C5");
GroupBucketStatusDTO.BucketInfo info = dto.getBuckets().get(0);
assertEquals(100, info.getAvailableTokens());
assertEquals(0.0, info.getUsagePercent(), 0.01);
}
// =========================================================================
// 전체 목록 조회
// =========================================================================
@Test
void getAllClientBucketStatus_twoEntries_returnsBoth() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
Map<String, DualCustomBucket> map = new ConcurrentHashMap<>();
map.put("CLIENT_A", makeDualBucket("CLIENT_A", 10, 1000));
map.put("CLIENT_B", makeDualBucket("CLIENT_B", 20, 2000));
when(manager.getClientBucketMap()).thenReturn(map);
List<TargetBucketStatusDTO> result = serviceWith(manager).getAllClientBucketStatus();
assertEquals(2, result.size());
}
}
@@ -0,0 +1,144 @@
package com.eactive.eai.custom.inflow;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.*;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.springframework.http.ResponseEntity;
import org.springframework.test.util.ReflectionTestUtils;
import com.eactive.eai.manage.inflow.TargetMetricDTO;
/**
* ClientInflowTargetMetricController 단위 테스트.
*
* <p>Spring MVC를 기동하지 않고 컨트롤러를 직접 인스턴스화하여
* 응답 구조(success, data, count, message)를 검증한다.
*/
class ClientInflowTargetMetricControllerTest {
private ClientInflowTargetMetricController controller;
private ClientInflowTargetMetricService mockService;
@BeforeEach
void setUp() {
controller = new ClientInflowTargetMetricController();
mockService = mock(ClientInflowTargetMetricService.class);
ReflectionTestUtils.setField(controller, "metricService", mockService);
}
private TargetMetricDTO makeDTO(String targetId, String targetType,
long allowed, long rejPs, long rejTh) {
TargetMetricDTO dto = new TargetMetricDTO();
dto.setTargetId(targetId);
dto.setTargetType(targetType);
dto.setActivate(true);
dto.setAllowed(allowed);
dto.setRejectedPerSecond(rejPs);
dto.setRejectedThreshold(rejTh);
long total = allowed + rejPs + rejTh;
dto.setTotalRequests(total);
dto.setRejectRatio(total > 0 ? (double)(rejPs + rejTh) / total * 100 : 0.0);
return dto;
}
@SuppressWarnings("unchecked")
private Map<String, Object> body(ResponseEntity<?> response) {
return (Map<String, Object>) response.getBody();
}
// =========================================================================
// 단일 조회
// =========================================================================
@Test
void getClientMetric_found_successTrueAndDataPresent() {
TargetMetricDTO dto = makeDTO("C1", "CLIENT", 300, 50, 20);
when(mockService.getClientMetric("C1")).thenReturn(dto);
Map<String, Object> body = body(controller.getClientMetric("C1"));
assertEquals(Boolean.TRUE, body.get("success"));
assertSame(dto, body.get("data"));
assertFalse(body.containsKey("message"));
}
@Test
void getClientMetric_notFound_successFalseWithMessage() {
when(mockService.getClientMetric("GHOST")).thenReturn(null);
Map<String, Object> body = body(controller.getClientMetric("GHOST"));
assertEquals(Boolean.FALSE, body.get("success"));
assertTrue(body.get("message").toString().contains("GHOST"));
}
// =========================================================================
// 전체 조회
// =========================================================================
@Test
void getAllClientMetrics_returnsListAndCount() {
List<TargetMetricDTO> list = Arrays.asList(
makeDTO("C1", "CLIENT", 100, 5, 5),
makeDTO("C2", "CLIENT", 200, 0, 0),
makeDTO("C3", "CLIENT", 50, 10, 0)
);
when(mockService.getAllClientMetrics()).thenReturn(list);
Map<String, Object> body = body(controller.getAllClientMetrics());
assertEquals(Boolean.TRUE, body.get("success"));
assertSame(list, body.get("data"));
assertEquals(3, body.get("count"));
}
@Test
void getAllClientMetrics_emptyList_countZero() {
when(mockService.getAllClientMetrics()).thenReturn(Collections.emptyList());
Map<String, Object> body = body(controller.getAllClientMetrics());
assertEquals(Boolean.TRUE, body.get("success"));
assertEquals(0, body.get("count"));
}
// =========================================================================
// reset
// =========================================================================
@Test
void resetClientMetric_success_successTrueWithTargetId() {
when(mockService.resetClientMetric("C1")).thenReturn(true);
Map<String, Object> body = body(controller.resetClientMetric("C1"));
assertEquals(Boolean.TRUE, body.get("success"));
assertTrue(body.get("message").toString().contains("C1"));
}
@Test
void resetClientMetric_notFound_successFalseWithTargetId() {
when(mockService.resetClientMetric("GHOST")).thenReturn(false);
Map<String, Object> body = body(controller.resetClientMetric("GHOST"));
assertEquals(Boolean.FALSE, body.get("success"));
assertTrue(body.get("message").toString().contains("GHOST"));
}
@Test
void resetAllClientMetrics_callsDelegateOnce() {
doNothing().when(mockService).resetAllClientMetrics();
controller.resetAllClientMetrics();
verify(mockService, times(1)).resetAllClientMetrics();
}
}
@@ -0,0 +1,177 @@
package com.eactive.eai.custom.inflow;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.*;
import java.util.List;
import org.junit.jupiter.api.Test;
import com.eactive.eai.common.inflow.InflowTargetVO;
import com.eactive.eai.common.inflow.dual.ClientDualInflowControlManager;
import com.eactive.eai.common.inflow.dual.DualInflowControlManager;
import com.eactive.eai.manage.inflow.TargetMetricDTO;
class ClientInflowTargetMetricServiceTest {
private static ClientInflowTargetMetricService serviceWith(ClientDualInflowControlManager manager) {
return new ClientInflowTargetMetricService() {
@Override
protected ClientDualInflowControlManager getClientDualManager() { return manager; }
};
}
private InflowTargetVO makeVO(String name) {
InflowTargetVO vo = new InflowTargetVO();
vo.setName(name);
vo.setActivate(true);
return vo;
}
private DualInflowControlManager.TargetMetrics makeMetrics(long allowed, long rejPs, long rejTh) {
DualInflowControlManager.TargetMetrics m = new DualInflowControlManager.TargetMetrics();
m.allowed.set(allowed);
m.rejectedPerSecond.set(rejPs);
m.rejectedThreshold.set(rejTh);
return m;
}
// =========================================================================
// null 관리자 (비활성 환경)
// =========================================================================
@Test
void getClientMetric_managerIsNull_returnsNull() {
assertNull(serviceWith(null).getClientMetric("C1"));
}
@Test
void getAllClientMetrics_managerIsNull_returnsEmptyList() {
assertTrue(serviceWith(null).getAllClientMetrics().isEmpty());
}
@Test
void resetClientMetric_managerIsNull_returnsFalse() {
assertFalse(serviceWith(null).resetClientMetric("C1"));
}
@Test
void resetAllClientMetrics_managerIsNull_noException() {
assertDoesNotThrow(() -> serviceWith(null).resetAllClientMetrics());
}
// =========================================================================
// 단일 조회
// =========================================================================
@Test
void getClientMetric_found_mapsFields() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(makeVO("C1"));
when(manager.getClientMetrics("C1")).thenReturn(makeMetrics(200, 30, 20));
TargetMetricDTO dto = serviceWith(manager).getClientMetric("C1");
assertNotNull(dto);
assertEquals("C1", dto.getTargetId());
assertEquals("CLIENT", dto.getTargetType());
assertTrue(dto.isActivate());
assertEquals(200, dto.getAllowed());
assertEquals(30, dto.getRejectedPerSecond());
assertEquals(20, dto.getRejectedThreshold());
assertEquals(250, dto.getTotalRequests());
}
@Test
void getClientMetric_notRegistered_returnsNull() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(null);
assertNull(serviceWith(manager).getClientMetric("C1"));
}
@Test
void getClientMetric_noMetricsYet_returnsZeroCounters() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(makeVO("C1"));
when(manager.getClientMetrics("C1")).thenReturn(null);
TargetMetricDTO dto = serviceWith(manager).getClientMetric("C1");
assertNotNull(dto);
assertEquals(0, dto.getAllowed());
assertEquals(0, dto.getTotalRequests());
assertEquals(0.0, dto.getRejectRatio(), 0.001);
}
@Test
void getClientMetric_rejectRatioCalculation() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(makeVO("C1"));
// allowed=90, rejPs=5, rejTh=5 → reject=10/100 = 10.00%
when(manager.getClientMetrics("C1")).thenReturn(makeMetrics(90, 5, 5));
TargetMetricDTO dto = serviceWith(manager).getClientMetric("C1");
assertEquals(10.0, dto.getRejectRatio(), 0.01);
}
// =========================================================================
// 전체 조회
// =========================================================================
@Test
void getAllClientMetrics_twoEntries_returnsBoth() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
java.util.Map<String, com.eactive.eai.common.inflow.dual.DualCustomBucket> bucketMap =
new java.util.LinkedHashMap<>();
bucketMap.put("C1", null);
bucketMap.put("C2", null);
when(manager.getClientBucketMap()).thenReturn(bucketMap);
when(manager.getClientInflowThreshold("C1")).thenReturn(makeVO("C1"));
when(manager.getClientInflowThreshold("C2")).thenReturn(makeVO("C2"));
when(manager.getClientMetrics("C1")).thenReturn(makeMetrics(10, 0, 0));
when(manager.getClientMetrics("C2")).thenReturn(makeMetrics(20, 5, 0));
List<TargetMetricDTO> result = serviceWith(manager).getAllClientMetrics();
assertEquals(2, result.size());
}
@Test
void getAllClientMetrics_noKeys_returnsEmptyList() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientBucketMap()).thenReturn(new java.util.HashMap<>());
assertTrue(serviceWith(manager).getAllClientMetrics().isEmpty());
}
// =========================================================================
// reset
// =========================================================================
@Test
void resetClientMetric_success_returnsTrueAndCallsManager() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(makeVO("C1"));
assertTrue(serviceWith(manager).resetClientMetric("C1"));
verify(manager).resetClientMetrics("C1");
}
@Test
void resetClientMetric_notRegistered_returnsFalseAndNoReset() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(null);
assertFalse(serviceWith(manager).resetClientMetric("C1"));
verify(manager, never()).resetClientMetrics(any());
}
@Test
void resetAllClientMetrics_callsManager() {
ClientDualInflowControlManager manager = mock(ClientDualInflowControlManager.class);
serviceWith(manager).resetAllClientMetrics();
verify(manager).resetAllClientMetrics();
}
}
@@ -18,6 +18,7 @@ import org.springframework.test.util.ReflectionTestUtils;
*
* <p>Spring MVC를 기동하지 않고 컨트롤러를 직접 인스턴스화하여
* 응답 구조(success, data, count, message)를 검증한다.
* 클라이언트 관련 테스트는 ClientInflowTargetBucketControllerTest 에서 검증한다.
*/
class InflowTargetBucketControllerTest {
@@ -148,64 +149,4 @@ class InflowTargetBucketControllerTest {
assertEquals(Boolean.TRUE, body.get("success"));
assertEquals(1, body.get("count"));
}
// =========================================================================
// 클라이언트 — 단일 조회
// =========================================================================
@Test
void getClientBucketStatus_found_successTrueAndDataPresent() {
TargetBucketStatusDTO dto = makeDTO("CLIENT_A", "CLIENT");
when(mockService.getClientBucketStatus("CLIENT_A")).thenReturn(dto);
ResponseEntity<?> response = controller.getClientBucketStatus("CLIENT_A");
Map<String, Object> body = body(response);
assertEquals(200, response.getStatusCodeValue());
assertEquals(Boolean.TRUE, body.get("success"));
assertSame(dto, body.get("data"));
assertFalse(body.containsKey("message"));
}
@Test
void getClientBucketStatus_notFound_successFalseWithClientId() {
when(mockService.getClientBucketStatus("CLIENT_X")).thenReturn(null);
ResponseEntity<?> response = controller.getClientBucketStatus("CLIENT_X");
Map<String, Object> body = body(response);
assertEquals(Boolean.FALSE, body.get("success"));
assertTrue(body.get("message").toString().contains("CLIENT_X"));
}
// =========================================================================
// 클라이언트 — 전체 조회
// =========================================================================
@Test
void getAllClientBucketStatus_returnsListAndCount() {
List<TargetBucketStatusDTO> list = Arrays.asList(
makeDTO("CLIENT_A", "CLIENT"),
makeDTO("CLIENT_B", "CLIENT"),
makeDTO("CLIENT_C", "CLIENT")
);
when(mockService.getAllClientBucketStatus()).thenReturn(list);
ResponseEntity<?> response = controller.getAllClientBucketStatus();
Map<String, Object> body = body(response);
assertEquals(Boolean.TRUE, body.get("success"));
assertSame(list, body.get("data"));
assertEquals(3, body.get("count"));
}
@Test
void getAllClientBucketStatus_emptyList_countZero() {
when(mockService.getAllClientBucketStatus()).thenReturn(Collections.emptyList());
Map<String, Object> body = body(controller.getAllClientBucketStatus());
assertEquals(Boolean.TRUE, body.get("success"));
assertEquals(0, body.get("count"));
}
}
@@ -21,8 +21,8 @@ import io.github.bucket4j.local.LocalBucket;
/**
* InflowTargetBucketService 단위 테스트.
*
* <p>getDualManager()를 protected로 오버라이드하는 내부 테스트 서브클래스 사용하여
* DualInflowControlManager 의존성을 주입한다.
* <p>어댑터/인터페이스: getDualManager()를 오버라이드하는 서브클래스 사용.
* 클라이언트 관련 테스트는 ClientInflowTargetBucketServiceTest 에서 검증한다.
*/
class InflowTargetBucketServiceTest {
@@ -33,9 +33,7 @@ class InflowTargetBucketServiceTest {
private static InflowTargetBucketService serviceWith(DualInflowControlManager manager) {
return new InflowTargetBucketService() {
@Override
protected DualInflowControlManager getDualManager() {
return manager;
}
protected DualInflowControlManager getDualManager() { return manager; }
};
}
@@ -96,16 +94,6 @@ class InflowTargetBucketServiceTest {
assertTrue(serviceWith(null).getAllInterfaceBucketStatus().isEmpty());
}
@Test
void getClientBucketStatus_managerIsNull_returnsNull() {
assertNull(serviceWith(null).getClientBucketStatus("CLIENT_A"));
}
@Test
void getAllClientBucketStatus_managerIsNull_returnsEmptyList() {
assertTrue(serviceWith(null).getAllClientBucketStatus().isEmpty());
}
// =========================================================================
// 버킷 미존재
// =========================================================================
@@ -126,14 +114,6 @@ class InflowTargetBucketServiceTest {
assertNull(serviceWith(manager).getInterfaceBucketStatus("IF_001"));
}
@Test
void getClientBucketStatus_notFound_returnsNull() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientBucket("CLIENT_A")).thenReturn(null);
assertNull(serviceWith(manager).getClientBucketStatus("CLIENT_A"));
}
// =========================================================================
// 단일 조회 — targetType, targetId 매핑
// =========================================================================
@@ -166,98 +146,10 @@ class InflowTargetBucketServiceTest {
assertEquals(2, dto.getBuckets().size());
}
@Test
void getClientBucketStatus_found_mapsClientType() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientBucket("CLIENT_A")).thenReturn(makeDualBucket("CLIENT_A", 50, 5000));
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("CLIENT_A");
assertNotNull(dto);
assertEquals("CLIENT_A", dto.getTargetId());
assertEquals("CLIENT", dto.getTargetType());
assertTrue(dto.isActivate());
assertEquals(2, dto.getBuckets().size());
}
// =========================================================================
// BucketInfo 타입별 포함 여부
// BucketInfo 용량/시간단위 매핑
// =========================================================================
@Test
void toDto_onlyThreshold_bucketInfoHasOneThresholdEntry() {
InflowTargetVO vo = makeVO("C1", 0, 1000, "DAY", true);
DualCustomBucket bucket = new DualCustomBucket(null, freshBucket(1000), vo);
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientBucket("C1")).thenReturn(bucket);
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C1");
assertEquals(1, dto.getBuckets().size());
assertEquals("threshold", dto.getBuckets().get(0).getType());
}
@Test
void toDto_onlyPerSecond_bucketInfoHasOnePerSecondEntry() {
InflowTargetVO vo = makeVO("C2", 100, 0, "SEC", true);
DualCustomBucket bucket = new DualCustomBucket(freshBucket(100), null, vo);
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientBucket("C2")).thenReturn(bucket);
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C2");
assertEquals(1, dto.getBuckets().size());
assertEquals("perSecond", dto.getBuckets().get(0).getType());
}
@Test
void toDto_bothBuckets_bucketInfoHasTwoEntries() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientBucket("C3")).thenReturn(makeDualBucket("C3", 100, 5000));
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C3");
assertEquals(2, dto.getBuckets().size());
assertEquals("perSecond", dto.getBuckets().get(0).getType());
assertEquals("threshold", dto.getBuckets().get(1).getType());
}
// =========================================================================
// 사용률 계산
// =========================================================================
@Test
void toDto_exhaustedThreshold_usagePercentIs100() {
InflowTargetVO vo = makeVO("C4", 0, 100, "DAY", true);
DualCustomBucket bucket = new DualCustomBucket(null, exhaustedBucket(100), vo);
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientBucket("C4")).thenReturn(bucket);
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C4");
GroupBucketStatusDTO.BucketInfo info = dto.getBuckets().get(0);
assertEquals(0, info.getAvailableTokens());
assertEquals(100.0, info.getUsagePercent(), 0.01);
}
@Test
void toDto_freshBucket_usagePercentIsZero() {
InflowTargetVO vo = makeVO("C5", 0, 100, "DAY", true);
DualCustomBucket bucket = new DualCustomBucket(null, freshBucket(100), vo);
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientBucket("C5")).thenReturn(bucket);
TargetBucketStatusDTO dto = serviceWith(manager).getClientBucketStatus("C5");
GroupBucketStatusDTO.BucketInfo info = dto.getBuckets().get(0);
assertEquals(100, info.getAvailableTokens());
assertEquals(0.0, info.getUsagePercent(), 0.01);
}
@Test
void toDto_capacity_perSecondBucketInfoCapacityMatchesVO() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
@@ -278,19 +170,6 @@ class InflowTargetBucketServiceTest {
// 전체 목록 조회
// =========================================================================
@Test
void getAllClientBucketStatus_twoEntries_returnsBoth() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
Map<String, DualCustomBucket> map = new ConcurrentHashMap<>();
map.put("CLIENT_A", makeDualBucket("CLIENT_A", 10, 1000));
map.put("CLIENT_B", makeDualBucket("CLIENT_B", 20, 2000));
when(manager.getClientBucketMap()).thenReturn(map);
List<TargetBucketStatusDTO> result = serviceWith(manager).getAllClientBucketStatus();
assertEquals(2, result.size());
}
@Test
void getAllAdapterBucketStatus_emptyMap_returnsEmptyList() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
@@ -210,92 +210,4 @@ class InflowTargetMetricControllerTest {
verify(mockService, times(1)).resetAllInterfaceMetrics();
}
// =========================================================================
// 클라이언트 — 단일 조회
// =========================================================================
@Test
void getClientMetric_found_successTrueAndDataPresent() {
TargetMetricDTO dto = makeDTO("C1", "CLIENT", 300, 50, 20);
when(mockService.getClientMetric("C1")).thenReturn(dto);
Map<String, Object> body = body(controller.getClientMetric("C1"));
assertEquals(Boolean.TRUE, body.get("success"));
assertSame(dto, body.get("data"));
}
@Test
void getClientMetric_notFound_successFalseWithMessage() {
when(mockService.getClientMetric("GHOST")).thenReturn(null);
Map<String, Object> body = body(controller.getClientMetric("GHOST"));
assertEquals(Boolean.FALSE, body.get("success"));
assertTrue(body.get("message").toString().contains("GHOST"));
}
// =========================================================================
// 클라이언트 — 전체 조회
// =========================================================================
@Test
void getAllClientMetrics_returnsListAndCount() {
List<TargetMetricDTO> list = Arrays.asList(
makeDTO("C1", "CLIENT", 100, 5, 5),
makeDTO("C2", "CLIENT", 200, 0, 0),
makeDTO("C3", "CLIENT", 50, 10, 0)
);
when(mockService.getAllClientMetrics()).thenReturn(list);
Map<String, Object> body = body(controller.getAllClientMetrics());
assertEquals(Boolean.TRUE, body.get("success"));
assertSame(list, body.get("data"));
assertEquals(3, body.get("count"));
}
@Test
void getAllClientMetrics_emptyList_countZero() {
when(mockService.getAllClientMetrics()).thenReturn(Collections.emptyList());
Map<String, Object> body = body(controller.getAllClientMetrics());
assertEquals(Boolean.TRUE, body.get("success"));
assertEquals(0, body.get("count"));
}
// =========================================================================
// 클라이언트 — reset
// =========================================================================
@Test
void resetClientMetric_success_successTrue() {
when(mockService.resetClientMetric("C1")).thenReturn(true);
Map<String, Object> body = body(controller.resetClientMetric("C1"));
assertEquals(Boolean.TRUE, body.get("success"));
assertTrue(body.get("message").toString().contains("C1"));
}
@Test
void resetClientMetric_notFound_successFalse() {
when(mockService.resetClientMetric("GHOST")).thenReturn(false);
Map<String, Object> body = body(controller.resetClientMetric("GHOST"));
assertEquals(Boolean.FALSE, body.get("success"));
assertTrue(body.get("message").toString().contains("GHOST"));
}
@Test
void resetAllClientMetrics_callsDelegateOnce() {
doNothing().when(mockService).resetAllClientMetrics();
controller.resetAllClientMetrics();
verify(mockService, times(1)).resetAllClientMetrics();
}
}
@@ -13,12 +13,12 @@ import com.eactive.eai.common.inflow.dual.DualInflowControlManager;
/**
* InflowTargetMetricService 단위 테스트.
*
* <p>getDualManager()를 오버라이드하여 DualInflowControlManager 의존성을 주입한다.
* <p>어댑터/인터페이스 테스트는 getDualManager()를 오버라이드하여 DualInflowControlManager 주입.
*/
class InflowTargetMetricServiceTest {
// -------------------------------------------------------------------------
// 테스트용 서브클래스
// 테스트용 서브클래스 — 어댑터/인터페이스용
// -------------------------------------------------------------------------
private static InflowTargetMetricService serviceWith(DualInflowControlManager manager) {
@@ -76,11 +76,6 @@ class InflowTargetMetricServiceTest {
assertNull(serviceWith(null).getInterfaceMetric("IF1"));
}
@Test
void getClientMetric_managerIsNull_returnsNull() {
assertNull(serviceWith(null).getClientMetric("C1"));
}
// =========================================================================
// 어댑터 — 단일 조회
// =========================================================================
@@ -271,55 +266,4 @@ class InflowTargetMetricServiceTest {
serviceWith(manager).resetAllInterfaceMetrics();
verify(manager).resetAllInterfaceMetrics();
}
// =========================================================================
// 클라이언트 — 단일 조회
// =========================================================================
@Test
void getClientMetric_found_mapsFields() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(makeVO("C1"));
when(manager.getClientMetrics("C1")).thenReturn(makeMetrics(200, 30, 20));
TargetMetricDTO dto = serviceWith(manager).getClientMetric("C1");
assertNotNull(dto);
assertEquals("C1", dto.getTargetId());
assertEquals("CLIENT", dto.getTargetType());
assertEquals(200, dto.getAllowed());
assertEquals(250, dto.getTotalRequests());
}
@Test
void getClientMetric_notRegistered_returnsNull() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(null);
assertNull(serviceWith(manager).getClientMetric("C1"));
}
@Test
void resetClientMetric_success_returnsTrueAndCallsManager() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(makeVO("C1"));
assertTrue(serviceWith(manager).resetClientMetric("C1"));
verify(manager).resetClientMetrics("C1");
}
@Test
void resetClientMetric_notRegistered_returnsFalse() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
when(manager.getClientInflowThreshold("C1")).thenReturn(null);
assertFalse(serviceWith(manager).resetClientMetric("C1"));
}
@Test
void resetAllClientMetrics_callsManager() {
DualInflowControlManager manager = mock(DualInflowControlManager.class);
serviceWith(manager).resetAllClientMetrics();
verify(manager).resetAllClientMetrics();
}
}